Skip to content

Conversation

justin-tahara
Copy link
Contributor

@justin-tahara justin-tahara commented Aug 5, 2025

Description

Bug with our helm chart release github action where the charts are maintained in a different location

[Provide a brief description of the changes in this PR]

How Has This Been Tested?

[Describe the tests you ran to verify your changes]
With the github action

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@justin-tahara justin-tahara requested a review from evan-onyx August 5, 2025 21:11
@justin-tahara justin-tahara requested a review from a team as a code owner August 5, 2025 21:11
Copy link

vercel bot commented Aug 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 9:11pm

@justin-tahara justin-tahara merged commit e2bae5a into main Aug 5, 2025
15 of 18 checks passed
@justin-tahara justin-tahara deleted the jtahara/fix-github-action-helm branch August 5, 2025 21:11
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR fixes a critical configuration issue in the Helm chart release GitHub Action workflow. The change addresses a bug where the helm/chart-releaser-action@v1.7.0 was failing to locate Helm charts because it was searching in the default charts directory, while the actual charts are maintained in deployment/helm/charts.

The fix adds an explicit charts_dir: deployment/helm/charts parameter to the chart-releaser action configuration. This aligns the release workflow with the existing chart testing workflow configuration found in ct.yaml, which already correctly specifies this directory structure. The change ensures consistency across all Helm-related CI/CD operations in the repository.

This is a straightforward infrastructure fix that resolves a path mismatch between the action's default behavior and the repository's actual directory structure. The onyx-stack Helm chart is located in the deployment/helm/charts directory, and this change ensures the release action can properly discover and process it.

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it's a simple configuration fix for a non-functional workflow
  • Score reflects the straightforward nature of the change and clear alignment with existing repository structure
  • No files require special attention as this is a single-line configuration addition

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

wenxi-onyx pushed a commit that referenced this pull request Aug 11, 2025
* feat(infra): Adding helm directory

* one more fix
AnkitTukatek pushed a commit to TukaTek/onyx that referenced this pull request Sep 23, 2025
* feat(infra): Adding helm directory

* one more fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants